-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps-dev): bump karma from 6.3.13 to 6.3.14 #1713
Conversation
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.13 to 6.3.14. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](karma-runner/karma@v6.3.13...v6.3.14) --- updated-dependencies: - dependency-name: karma dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
I am impressed that these automated pull requests are actually catching all (?) the sub packages. Are these PRs actually mergable (and do we want to)? 🤔 |
ha yeah that is cool. i guess there is no harm merging, but i assume when we refresh the package-lock prior to releases we'll automatically get it anyway |
we can merge this to provide more safety to our collaborators who are actively working on the monorepo. this is the security fix commit: karma-runner/karma@839578c doesn't seem to be something that would really affect us |
On the other hand: this brings in a lot of unrest into the repository, now e.g. we have to of these PRs open from dependabot already and this always interrupts the normal PR merge flow standing towards the situation that we a) regularly updating the So I would have a tendency to just close these and deactivate dependabot for now (this has been auto-activated by GitHub, right?). Respectively: I'll do for now, let me know if you have a somewhat stronger opinion here and disagree and think we should rather keep it running. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Ah, couldn't quickly find the settings to disable (or aren't there any?), so will leave for now. |
Looks like it might be here: https://docs.github.com/en/code-security/supply-chain-security/managing-vulnerabilities-in-your-projects-dependencies/configuring-dependabot-security-updates#enabling-or-disabling-dependabot-security-updates-for-an-individual-repository The real thing is I think we would rather be notified when it matches our "dependencies" not "devDeps" (just googled, dependabot/dependabot-core#4146) Most of the time it's something that doesn't apply to us, but in the rare case that is and would require a patch release, would be nice to be know. I would think better to triage through dependabot (closing an unnecessary PR) than a looming disaster. |
Bumps karma from 6.3.13 to 6.3.14.
Release notes
Sourced from karma's releases.
Changelog
Sourced from karma's changelog.
Commits
c97e562
chore(release): 6.3.14 [skip ci]91d5acd
fix: remove string template from client code69cfc76
fix: warn whensingleRun
andautoWatch
arefalse
839578c
fix(security): remove XSS vulnerability inreturnUrl
query paramDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.