Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump karma from 6.3.13 to 6.3.14 #1713

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 11, 2022

Bumps karma from 6.3.13 to 6.3.14.

Release notes

Sourced from karma's releases.

v6.3.14

6.3.14 (2022-02-05)

Bug Fixes

  • remove string template from client code (91d5acd)
  • warn when singleRun and autoWatch are false (69cfc76)
  • security: remove XSS vulnerability in returnUrl query param (839578c)
Changelog

Sourced from karma's changelog.

6.3.14 (2022-02-05)

Bug Fixes

  • remove string template from client code (91d5acd)
  • warn when singleRun and autoWatch are false (69cfc76)
  • security: remove XSS vulnerability in returnUrl query param (839578c)
Commits
  • c97e562 chore(release): 6.3.14 [skip ci]
  • 91d5acd fix: remove string template from client code
  • 69cfc76 fix: warn when singleRun and autoWatch are false
  • 839578c fix(security): remove XSS vulnerability in returnUrl query param
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [karma](https://github.com/karma-runner/karma) from 6.3.13 to 6.3.14.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](karma-runner/karma@v6.3.13...v6.3.14)

---
updated-dependencies:
- dependency-name: karma
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 11, 2022
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #1713 (2a0f805) into master (e4f6c11) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
block 85.57% <ø> (ø)
blockchain 83.28% <ø> (ø)
client 72.04% <ø> (ø)
common 93.89% <ø> (ø)
devp2p 82.63% <ø> (ø)
ethash 90.76% <ø> (ø)
rlp 90.55% <ø> (ø)
trie 86.18% <ø> (ø)
tx 89.94% <ø> (ø)
util 92.62% <ø> (ø)
vm 81.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member

I am impressed that these automated pull requests are actually catching all (?) the sub packages. Are these PRs actually mergable (and do we want to)? 🤔

@ryanio
Copy link
Contributor

ryanio commented Feb 11, 2022

ha yeah that is cool. i guess there is no harm merging, but i assume when we refresh the package-lock prior to releases we'll automatically get it anyway

@ryanio
Copy link
Contributor

ryanio commented Feb 11, 2022

we can merge this to provide more safety to our collaborators who are actively working on the monorepo.

this is the security fix commit: karma-runner/karma@839578c doesn't seem to be something that would really affect us

@holgerd77
Copy link
Member

On the other hand: this brings in a lot of unrest into the repository, now e.g. we have to of these PRs open from dependabot already and this always interrupts the normal PR merge flow standing towards the situation that we a) regularly updating the package-lock.json ourselves and b) do not do releases that frequently.

So I would have a tendency to just close these and deactivate dependabot for now (this has been auto-activated by GitHub, right?).

Respectively: I'll do for now, let me know if you have a somewhat stronger opinion here and disagree and think we should rather keep it running.

@holgerd77 holgerd77 closed this Feb 14, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 14, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/karma-6.3.14 branch February 14, 2022 10:28
@holgerd77
Copy link
Member

Ah, couldn't quickly find the settings to disable (or aren't there any?), so will leave for now.

@ryanio
Copy link
Contributor

ryanio commented Feb 14, 2022

Ah, couldn't quickly find the settings to disable (or aren't there any?), so will leave for now.

Looks like it might be here: https://docs.github.com/en/code-security/supply-chain-security/managing-vulnerabilities-in-your-projects-dependencies/configuring-dependabot-security-updates#enabling-or-disabling-dependabot-security-updates-for-an-individual-repository

The real thing is I think we would rather be notified when it matches our "dependencies" not "devDeps" (just googled, dependabot/dependabot-core#4146)

Most of the time it's something that doesn't apply to us, but in the rare case that is and would require a patch release, would be nice to be know. I would think better to triage through dependabot (closing an unnecessary PR) than a looming disaster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants